Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make links clickable in notes #286

Merged
merged 3 commits into from Nov 13, 2014
Merged

Make links clickable in notes #286

merged 3 commits into from Nov 13, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Nov 12, 2014

Use auto_link gem to create links from URLs within edition notes.

screen shot 2014-11-12 at 18 29 58

fofr added 3 commits Nov 11, 2014
* Cleanup the view and move logic to a helper
* Only link URLs not emails
* Don’t sanitize the output so as to be consistent with simple_format
options
vinayvinay added a commit that referenced this pull request Nov 13, 2014
@vinayvinay vinayvinay merged commit 276ca76 into master Nov 13, 2014
1 check passed
1 check passed
default "Build #398 succeeded on Jenkins"
Details
@vinayvinay vinayvinay deleted the links-in-notes branch Nov 13, 2014
<% if action.recipient_id.present? %>
Assigned to <%= mail_to action.recipient.email, action.recipient.name %>
<% end %>
<%= action_note(action).html_safe %>

This comment has been minimized.

@alext

alext Nov 13, 2014
Contributor

This feels like the wrong place to have the html_safe call. I think this would be better within the helper. That way it can be as focussed as possible.

@vinayvinay
Copy link
Contributor

@vinayvinay vinayvinay commented Nov 13, 2014

@fofr: though this is merged, commits don't appear on master. we're suspecting master was forcefully re-written. I'll hold-off merging this manually on the console, because @alext has some feedback. i've restored the branch, so that you can work on it again and create another PR.

@vinayvinay vinayvinay restored the links-in-notes branch Nov 13, 2014
@fofr fofr deleted the links-in-notes branch Nov 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.