Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify page titles #294

Merged
merged 2 commits into from Nov 14, 2014
Merged

Simplify page titles #294

merged 2 commits into from Nov 14, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Nov 14, 2014

screen shot 2014-11-14 at 15 20 58
screen shot 2014-11-14 at 15 20 33

screen shot 2014-11-14 at 15 21 13
screen shot 2014-11-14 at 15 20 42

fofr added 2 commits Nov 14, 2014
* Viewing “…” is unnecessary
* Remove extraneous quotes and nouns
alext added a commit that referenced this pull request Nov 14, 2014
@alext alext merged commit bebcc59 into master Nov 14, 2014
1 check passed
1 check passed
default "Build #421 succeeded on Jenkins"
Details
@alext alext deleted the simplify-titles branch Nov 14, 2014
alext added a commit to alphagov/smokey that referenced this pull request Nov 17, 2014
The title was changed in alphagov/publisher#294,
resulting in this test failing.  This removes the check for specific
words in the title, and leaves it checking for the publications list
itself using the HTML id.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.