Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include fact check request recipients in note #298

Merged
merged 1 commit into from Nov 18, 2014
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Nov 17, 2014

Fixes https://www.agileplannerapp.com/boards/173808/cards/8677

Previous refactor led to a regression where if a user provided a comment along with a fact check request the email addresses of that request wouldn't be displayed.

  • Show both comment and email addresses
  • Include test to document behaviour
  • Format mailto address to remove spaces, a mailto which contains spaces is an invalid link

Thanks @vinayvinay

Refactor led to a regression where if a user provided a comment along
with a fact check request, the email addresses wouldn’t be displayed.

* Show both comment and email addresses
* Include test to document behaviour
* Format mailto address to remove spaces, a mailto which contains
spaces is an invalid link
vinayvinay added a commit that referenced this pull request Nov 18, 2014
Include fact check request recipients in note
@vinayvinay vinayvinay merged commit f1475a8 into master Nov 18, 2014
1 check passed
1 check passed
default "Build #438 succeeded on Jenkins"
Details
@vinayvinay vinayvinay deleted the fix-action-fact-check branch Nov 18, 2014
@vinayvinay
Copy link
Contributor

@vinayvinay vinayvinay commented Nov 18, 2014

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.