Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid submitting business support form with JS #299

Merged
merged 1 commit into from Nov 18, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Nov 17, 2014

Fixes https://www.agileplannerapp.com/boards/173808/cards/7908

The update action for an edition relies on the value of the commit button submitted with the form. By intercepting the form submit and resubmitting after a DOM modification (which only happens on business support) we lose that context.

  • Don’t prevent default and avoid submitting form with JS
  • Instead let the event bubble up and perform its default action, submitting the form as the user originally intended
  • Include comment to note that this is intentional

(This only seemed to be a problem within Firefox)

The update action for an edition relies on the value of the commit
button submitted with the form. By intercepting the form submit and
resubmitting after a DOM modification we lose that context.

* Don’t prevent default and avoid submitting form with JS
* Instead let the event bubble up and perform its default action,
submitting the form as the user originally intended

(This only seemed to be a problem within Firefox)
@fofr fofr force-pushed the firefox-business-support-fix branch from 28da2c0 to 8a6863a Nov 17, 2014
vinayvinay added a commit that referenced this pull request Nov 18, 2014
Avoid submitting business support form with JS
@vinayvinay vinayvinay merged commit 9cd159c into master Nov 18, 2014
1 check passed
1 check passed
default "Build #441 succeeded on Jenkins"
Details
@vinayvinay vinayvinay deleted the firefox-business-support-fix branch Nov 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.