Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick cleanup of admin tab on editions #300

Merged
merged 2 commits into from Nov 18, 2014
Merged

Quick cleanup of admin tab on editions #300

merged 2 commits into from Nov 18, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Nov 18, 2014

  • Remove big red talk to a dev message and email
  • Be clear that it's an edition that's being deleted, and include the edition number
  • Add titles to action sections
  • Give feedback when an edition type can't be switched to another format

Before

screen shot 2014-11-18 at 11 40 32

After

screen shot 2014-11-18 at 11 40 43

fofr added 2 commits Nov 18, 2014
* Remove big red talk to a dev message and email
* Add headers to each section
* Indicate on the delete that only this edition will be deleted, and
which edition that is
@wryobservations
Copy link

@wryobservations wryobservations commented Nov 18, 2014

Lisa Scott
lisa.scott@digital.cabinet-office.gov.uk

On 18 Nov 2014, at 11:43, Paul Hayes notifications@github.com wrote:

Remove big red talk to a dev message and email
Be clear that it's an edition that's being deleted, and include the edition number
Add titles to action sections
Give feedback when an edition type can't be switched to another format
Before

After

You can merge this Pull Request by running

git pull https://github.com/alphagov/publisher talk-to-a-dev
Or view, comment on, or merge it at:

#300

Commit Summary

Tidy up admin tab
Give feedback when an edition can't change format
File Changes

M app/views/shared/_admin_buttons.html.erb (57)
M app/views/shared/_clone_buttons.html.erb (10)
M test/integration/edition_workflow_test.rb (2)
Patch Links:

https://github.com/alphagov/publisher/pull/300.patch
https://github.com/alphagov/publisher/pull/300.diff

Reply to this email directly or view it on GitHub.

alext added a commit that referenced this pull request Nov 18, 2014
Quick cleanup of admin tab on editions
@alext alext merged commit 8cb556f into master Nov 18, 2014
1 check passed
1 check passed
default "Build #444 succeeded on Jenkins"
Details
@alext alext deleted the talk-to-a-dev branch Nov 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.