Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily fix Chrome 38 multiple-select bug #301

Merged
merged 1 commit into from Nov 18, 2014
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Nov 18, 2014

A temporary fix for: https://code.google.com/p/chromium/issues/detail?id=423256 (see also: http://jsfiddle.net/1z1tskwh/4/)

When an item is preselected for a <select> which can have multiple values, Chrome 38 scrolls down the page. This makes editing and reviewing editions difficult. This is a temporary fix that scrolls the page back to the top on Chrome versions lower than 39.

This fix should be removed when Chrome 39 has been released.

A temporary scroll fix for
https://code.google.com/p/chromium/issues/detail?id=423256

This fix should be removed when Chrome 39 has been released.
@wryobservations
Copy link

@wryobservations wryobservations commented Nov 18, 2014

👍

Lisa Scott
lisa.scott@digital.cabinet-office.gov.uk

On 18 Nov 2014, at 12:26, Paul Hayes notifications@github.com wrote:

A temporary fix for: https://code.google.com/p/chromium/issues/detail?id=423256 (see also: http://jsfiddle.net/1z1tskwh/4/)

When an item is preselected for a which can have multiple values, Chrome 38 scrolls down the page. This makes editing and reviewing editions difficult. This is a temporary fix that scrolls the page back to the top on Chrome versions lower than 39. This fix should be removed when Chrome 39 has been released. You can merge this Pull Request by running git pull https://github.com/alphagov/publisher temp-fix-page-scroll Or view, comment on, or merge it at: https://github.com//pull/301 Commit Summary Fix Chrome 38 multiple-select bug File Changes A app/assets/javascripts/modules/chrome_fix.js (15) M app/views/shared/_edition_header.html.erb (2) Patch Links: https://github.com//pull/301.patch https://github.com//pull/301.diff — Reply to this email directly or view it on GitHub.

steventux added a commit that referenced this pull request Nov 18, 2014
Temporarily fix Chrome 38 multiple-select bug
@steventux steventux merged commit 22fbe88 into master Nov 18, 2014
1 check passed
1 check passed
default "Build #446 succeeded on Jenkins"
Details
@steventux steventux deleted the temp-fix-page-scroll branch Nov 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.