Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notices to success or danger flash messages #302

Merged
merged 1 commit into from Nov 19, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Nov 19, 2014

Be clearer about a success or failure using Bootstrap alert styles.

:notice and :alert are still used by inherited_resources and responders gems, customising the flash keys doesn’t work because of the old versions being used.

  • Explicitly set :success or :danger flash messages in app
  • Coerce :notice to a success message
  • Coerce :alert to a danger one

screen shot 2014-11-19 at 10 38 53

Be clearer about a success or failure using Bootstrap alert styles.

:notice and :alert are still used by inherited_resources and responders
gems, customising the flash keys doesn’t work because of the old
versions being used.

* Explicitly set :success or :danger flash messages in app
* Coerce :notice to a success message
* Coerce :alert to a danger one
@vinayvinay
Copy link
Contributor

@vinayvinay vinayvinay commented Nov 19, 2014

@fofr - does upgrading to the latest inherited resources look like a daunting task?

@fofr
Copy link
Contributor Author

@fofr fofr commented Nov 19, 2014

@vinayvinay It looked larger than this story. I think we should upgrade in another story (or, if we upgrade to Rails 4, refactor it out, as it's no longer maintained).

vinayvinay added a commit that referenced this pull request Nov 19, 2014
Update notices to success or danger flash messages
@vinayvinay vinayvinay merged commit d609851 into master Nov 19, 2014
1 check passed
1 check passed
default "Build #447 succeeded on Jenkins"
Details
@vinayvinay vinayvinay deleted the conspicuous-affirmations branch Nov 19, 2014
@fofr fofr mentioned this pull request Dec 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.