Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chrome fix now Chrome 39 is out #307

Merged
merged 1 commit into from Dec 19, 2014
Merged

Remove chrome fix now Chrome 39 is out #307

merged 1 commit into from Dec 19, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Nov 21, 2014

Undoes #301 and 5dbb076

Chrome 39 launched a day after the fix and is now appearing in automatic updates. We can remove the scroll hack.

Undoes 5dbb076
@alext
Copy link
Contributor

@alext alext commented Nov 21, 2014

👍
It's probably worth holding off on merging this for a day or 2 to allow time for updates to happen though.

@fofr
Copy link
Contributor Author

@fofr fofr commented Nov 21, 2014

I agree, I've left it a few days already and I figured the weekend would be a good buffer too. Happy to merge early next week.

@fofr
Copy link
Contributor Author

@fofr fofr commented Nov 28, 2014

Analytics still shows 50% of Chrome users on Version 38, holding off merging for a bit longer.

@fofr fofr closed this Nov 28, 2014
@fofr fofr reopened this Dec 3, 2014
@fofr fofr closed this Dec 3, 2014
@alext
Copy link
Contributor

@alext alext commented Dec 3, 2014

That still leave 18% on older chrome. I think we should leave this for a bit longer.

@fofr
Copy link
Contributor Author

@fofr fofr commented Dec 19, 2014

<1% on older Chrome now.

@fofr fofr reopened this Dec 19, 2014
alext added a commit that referenced this pull request Dec 19, 2014
Remove chrome fix now Chrome 39 is out
@alext alext merged commit 8fdde2b into master Dec 19, 2014
1 check passed
1 check passed
default "Build #451 succeeded on Jenkins"
Details
@alext alext deleted the remove-chrome-fix branch Dec 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.