Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak messaging and secondary field sizes #323

Merged
merged 2 commits into from Dec 5, 2014
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Dec 4, 2014

  • Increase vertical space for transaction fields. Intro paragraph boxes were too short, making it hard to write and review the content.
  • Tweak "can't edit" messaging

Before

screen shot 2014-12-04 at 10 56 22

After

screen shot 2014-12-04 at 10 55 02
screen shot 2014-12-04 at 10 53 45

@wryobservations
Copy link

@wryobservations wryobservations commented Dec 4, 2014

👍

Lisa Scott
Product Manager, GOV.UK
Government Digital Service, Aviation House, 125 Kingsway, London WC2B 6NH

lisa.scott@digital.cabinet-office.gov.uk

Product updates for GOV.UK: https://insidegovuk.blog.gov.uk/
GDS blog: http://digital.cabinetoffice.gov.uk/

Please use the support form! https://www.gov.uk/support/internal

On 4 Dec 2014, at 11:05, Paul Hayes notifications@github.com wrote:

Increase vertical space for transaction fields. Intro paragraph boxes were too short, making it hard to write and review the content.
Tweak "can't edit" messaging
Depends on #320 being merged for admin gem bump.

Before

After

You can merge this Pull Request by running

git pull https://github.com/alphagov/publisher introductory-paragraph
Or view, comment on, or merge it at:

#323

Commit Summary

Increase vertical space for transaction fields
Tweak "can't edit" messaging
File Changes

M app/views/business_supports/_additional_fields.html.erb (2)
M app/views/local_transactions/_fields.html.erb (2)
M app/views/shared/_edition_header.html.erb (9)
M app/views/transactions/_fields.html.erb (2)
Patch Links:

https://github.com/alphagov/publisher/pull/323.patch
https://github.com/alphagov/publisher/pull/323.diff

Reply to this email directly or view it on GitHub.

fofr added 2 commits Dec 4, 2014
* Intro paragraph boxes were too short, making it hard to write and
review the content.
* Use the callout pattern rather than a heavier alert
* Use smart quotes
* Refine copy
@fofr fofr force-pushed the introductory-paragraph branch from bbebdf9 to d73e49f Dec 4, 2014
alext added a commit that referenced this pull request Dec 5, 2014
Tweak messaging and secondary field sizes
@alext alext merged commit b22d92d into master Dec 5, 2014
1 check passed
1 check passed
default "Build #506 succeeded on Jenkins"
Details
@alext alext deleted the introductory-paragraph branch Dec 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.