Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add publication format to edition view #330

Merged
merged 1 commit into from Dec 12, 2014
Merged

Add publication format to edition view #330

merged 1 commit into from Dec 12, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Dec 11, 2014

Make it clear what type of format is being viewed.
Also shorten text used for editions and statuses.

Before

screen shot 2014-12-11 at 13 36 52

After

screen shot 2014-12-11 at 13 36 29

Make it clear what type of format is being viewed. Also shorten text
used for editions and statuses.
@wryobservations
Copy link

@wryobservations wryobservations commented Dec 11, 2014

👍

Lisa Scott
lisa.scott@digital.cabinet-office.gov.uk

On 11 Dec 2014, at 13:38, Paul Hayes notifications@github.com wrote:

Make it clear what type of format is being viewed.
Also shorten text used for editions and statuses.

Before

After

You can merge this Pull Request by running

git pull https://github.com/alphagov/publisher format-on-edition
Or view, comment on, or merge it at:

#330

Commit Summary

Add publication format to edition view
File Changes

M app/views/shared/_edition_header.html.erb (5)
M test/integration/business_support_create_edit_test.rb (6)
M test/integration/campaign_edit_test.rb (6)
M test/integration/completed_transactions_create_edit_test.rb (8)
M test/integration/edition_scheduled_publishing_test.rb (8)
M test/integration/edition_workflow_test.rb (8)
M test/integration/guide_create_edit_test.rb (6)
M test/integration/help_page_create_edit_test.rb (6)
M test/integration/licence_create_edit_test.rb (6)
M test/integration/local_transaction_create_edit_test.rb (6)
M test/integration/video_edition_create_edit_test.rb (4)
Patch Links:

https://github.com/alphagov/publisher/pull/330.patch
https://github.com/alphagov/publisher/pull/330.diff

Reply to this email directly or view it on GitHub.

vinayvinay added a commit that referenced this issue Dec 12, 2014
Add publication format to edition view
@vinayvinay vinayvinay merged commit af7a522 into master Dec 12, 2014
1 check passed
@vinayvinay vinayvinay deleted the format-on-edition branch Dec 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants