Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve legibility of diff views #335

Merged
merged 1 commit into from Dec 16, 2014
Merged

Improve legibility of diff views #335

merged 1 commit into from Dec 16, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Dec 16, 2014

New lines were displaying as thin strips. Spaces between lines made making comparisons more difficult. The +/- signs were hard to read against grey text.

  • Give each line in the diff a minimum height, making new lines display thicker and maintaining a vertical rhythm
  • Remove space between lines, the content naturally provides this spacing
  • Extend red/green highlight to edges of the view
  • Use darker red and green colours for the +/- icons

Before

screen shot 2014-12-16 at 11 25 21

After

screen shot 2014-12-16 at 11 25 37

New lines were displaying as thin strips. Spaces between lines made
making comparisons more difficult. The +/- signs were hard to read
against grey text.

* Give each line in the diff a minimum height, making new lines display
thicker and maintaining a vertical rhythm
* Remove space between lines, the content naturally provides this
spacing
* Extend red/green highlight to edges of the view
* Use darker red and green colours for the +/- icons
alext added a commit that referenced this pull request Dec 16, 2014
Improve legibility of diff views
@alext alext merged commit 2a21900 into master Dec 16, 2014
1 check passed
1 check passed
default "Build #535 succeeded on Jenkins"
Details
@alext alext deleted the clearer-diffs branch Dec 16, 2014
fofr added a commit to alphagov/travel-advice-publisher that referenced this pull request Dec 23, 2014
New lines were displaying as thin strips. Spaces between lines made
making comparisons more difficult. The +/- signs were hard to read
against grey text.

* Give each line in the diff a minimum height, making new lines display
thicker and maintaining a vertical rhythm
* Remove space between lines, the content naturally provides this
spacing
* Extend red/green highlight to edges of the view
* Use darker red and green colours for the +/- icons

Based on alphagov/publisher#335
fofr added a commit to alphagov/travel-advice-publisher that referenced this pull request Dec 23, 2014
New lines were displaying as thin strips. Spaces between lines made
making comparisons more difficult. The +/- signs were hard to read
against grey text.

* Give each line in the diff a minimum height, making new lines display
thicker and maintaining a vertical rhythm
* Remove space between lines, the content naturally provides this
spacing
* Extend red/green highlight to edges of the view
* Use darker red and green colours for the +/- icons

Based on alphagov/publisher#335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.