Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't let ‘Claim 2i’ work when an edition is already claimed #344

Merged
merged 1 commit into from Jan 5, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jan 2, 2015

If a user opens the “In review” list and leaves it for a while, they may come back to it and click “Claim 2i” later, eg if they’ve finished reviewing something else.

If in the meantime someone had already claimed the edition, the old behaviour would overwrite that reviewer. The old reviewer wouldn’t be notified, and the new reviewer wouldn’t know to tell them.

  • Prevent claiming of 2i when there’s already a reviewer
If a user opens the “In review” list and leaves it for a while, they
may come back to it and click “Claim 2i” later, eg if they’ve finished
reviewing something else.

If in the meantime someone had already claimed the edition, the old
behaviour would overwrite that reviewer. The old reviewer wouldn’t be
notified, and the new reviewer wouldn’t know to tell them.

* Prevent claiming of 2i when there’s already a reviewer
vinayvinay added a commit that referenced this pull request Jan 5, 2015
Don't let ‘Claim 2i’ work when an edition is already claimed
@vinayvinay vinayvinay merged commit 9dc2b39 into master Jan 5, 2015
1 check passed
1 check passed
default "Build #565 succeeded on Jenkins"
Details
@vinayvinay vinayvinay deleted the cant-claim-when-claimed branch Jan 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.