Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve display of important note changes #347

Merged
merged 5 commits into from Jan 13, 2015
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jan 12, 2015

  • Remove important note changes from edition history, important notes don't need to be visible within an edition’s audit trail.
  • When an important note has been modified, include details of who changed it and when in a table, hidden behind a toggle until it’s needed.
  • Make links and zendesk tickets in important notes clickable
  • Make important note content bigger and bolder

https://www.agileplannerapp.com/boards/173808/cards/9004
https://govuk.zendesk.com/tickets/898008

Prototype: 9254fad#commitcomment-9174019

Before

screen shot 2015-01-12 at 18 45 58

After

screen shot 2015-01-12 at 18 25 32
screen shot 2015-01-12 at 18 25 41

fofr added 5 commits Jan 12, 2015
Important notes don't need to be visible within an edition’s audit
trail.
* Notes are being missed, they should have a stronger presence on the
page
* Make them bolder and redder
* Reduce clutter around them, make the note the focus, rather than the
title, date and author
* Fix tests that were referring to a selector that had already been
removed
Separate from edition header before refactoring
Treat an important note in the same way as an action comment. Make
links and zen desk ticket numbers clickable to make notes more useful.
When an important note has been modified, include details of who
changed it and when in a table, hidden behind a toggle until it’s
needed.

* Allow users to find out who wrote which part of a note
* Easily see when modifications were made
* Indicate whether a user was creating or updating the note
@fofr fofr force-pushed the better-important-notes branch from aa4a671 to 4d6fe9a Jan 12, 2015
vinayvinay added a commit that referenced this pull request Jan 13, 2015
Improve display of important note changes
@vinayvinay vinayvinay merged commit 935bc6a into master Jan 13, 2015
1 check passed
1 check passed
default "Build #581 succeeded on Jenkins"
Details
@vinayvinay vinayvinay deleted the better-important-notes branch Jan 13, 2015
@vinayvinay
Copy link
Contributor

@vinayvinay vinayvinay commented Jan 13, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.