Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downtime messages begin at midnight the day before #354

Merged
merged 1 commit into from Jan 16, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jan 16, 2015

Update the messaging to reflect this.
cc @vinayvinay

Update the messaging to reflect this.
vinayvinay added a commit that referenced this pull request Jan 16, 2015
Downtime messages begin at midnight the day before
@vinayvinay vinayvinay merged commit 4ff5414 into master Jan 16, 2015
1 check passed
1 check passed
default "Build #598 succeeded on Jenkins"
Details
@vinayvinay vinayvinay deleted the downtime-schedule-message branch Jan 16, 2015
@alext
Copy link
Contributor

@alext alext commented Jan 16, 2015

Won't that lead to some confusion as people aren't necessarily clear on whether "midnight on Wednesday 31 December" means the beginning of Wednesday, or the end of Wednesday?

@fofr
Copy link
Contributor Author

@fofr fofr commented Jan 16, 2015

Yes, perhaps. If that is the case we can easily move to 1am.

@vinayvinay
Copy link
Contributor

@vinayvinay vinayvinay commented Jan 16, 2015

how about just: 'A downtime message will show from Wednesday 31 December'?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.