Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter expand/collapse text when adding/removing parts #357

Merged
merged 1 commit into from Feb 2, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jan 22, 2015

Use the events emitted by the nested form javascript to trigger changes in the link text for collapsing or expanding groups. Also remove the “if valid” check on the collapse class. All parts are shown expanded at page load, and all should be collapsible.

For example:

  • When a part is added and all parts were collapsed, change text to “expand”
  • When a part is removed and it was the only open part, change text to “expand”
@fofr fofr force-pushed the collapse-all-new-groups branch from 5515ab1 to da8737a Jan 29, 2015
@fofr
Copy link
Contributor Author

@fofr fofr commented Jan 29, 2015

Rebased with master so it's merge-able again.

@fofr
Copy link
Contributor Author

@fofr fofr commented Feb 2, 2015

Intermittent test failures being addressed in #362

Use the events emitted by the nested form javascript to trigger changes
in the link text for collapsing or expanding groups.

For example:
* When a part is added and all parts were collapsed, change text to
“expand”
* When a part is removed and it was the only open part, change text to
“expand”

* Remove the “if valid” check on the collapse class. All parts are
shown expanded at page load, and all should be collapsible.
@fofr fofr force-pushed the collapse-all-new-groups branch from da8737a to a713638 Feb 2, 2015
@vinayvinay
Copy link
Contributor

@vinayvinay vinayvinay commented Feb 2, 2015

Good for merge once build goes green.

fofr added a commit that referenced this pull request Feb 2, 2015
Alter expand/collapse text when adding/removing parts
@fofr fofr merged commit 936f66b into master Feb 2, 2015
1 check passed
1 check passed
default "Build #625 succeeded on Jenkins"
Details
@fofr fofr deleted the collapse-all-new-groups branch Feb 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.