Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only save when the save button is visible and enabled #365

Merged
merged 1 commit into from Feb 9, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Feb 6, 2015

Using keyboard shortcuts, the form could still be submitted when the save button is disabled or when it’s not visible (eg from a different tab). This behaviour was spotted via analytics events.

  • Only allow keyboard shortcut to work when the save button is visible and enabled.
Using keyboard shortcuts, the form could still be submitted while the
save button is disabled or when it’s not visible (eg from a different
tab). This behaviour was spotted via analytics events.

* Only allow keyboard shortcut to work when the save button is visible
and enabled.
@dhwthompson
Copy link
Contributor

@dhwthompson dhwthompson commented Feb 6, 2015

This looks thoroughly sensible to me, and it all looks like it works, but I’ll hold off merging until someone who knows JavaScript more better than I do has seen it.

vinayvinay added a commit that referenced this pull request Feb 9, 2015
Only save when the save button is visible and enabled
@vinayvinay vinayvinay merged commit 732168e into master Feb 9, 2015
1 check passed
1 check passed
default "Build #634 succeeded on Jenkins"
Details
@vinayvinay vinayvinay deleted the save-only-on-tab branch Feb 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.