Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix downtime slug links in production #368

Merged
merged 1 commit into from Feb 11, 2015
Merged

Fix downtime slug links in production #368

merged 1 commit into from Feb 11, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Feb 10, 2015

The slugs were linking to:
https://www.production.alphagov.co.uk/apply-universal-credit

Instead of:
https://www.gov.uk/apply-universal-credit

  • Use the public website root, ie the GOVUK_WEBSITE_ROOT environment variable, instead of find(‘www’)

https://www.pivotaltracker.com/story/show/87991876

The slugs were linking to:
https://www.production.alphagov.co.uk/apply-universal-credit

Instead of:
https://www.gov.uk/apply-universal-credit

Instead of `find(‘www’)`, use the public website root, ie the
GOVUK_WEBSITE_ROOT environment variable.
@alext
Copy link
Contributor

@alext alext commented Feb 10, 2015

Would be good if there was a test to cover this...

@fofr
Copy link
Contributor Author

@fofr fofr commented Feb 11, 2015

Discussed adding a test with @alext on Slack and it's not trivial. Plek now has better documentation.

Tests are all passing now. Happy to merge @alext?

alext added a commit that referenced this pull request Feb 11, 2015
Fix downtime slug links in production
@alext alext merged commit 9a564fb into master Feb 11, 2015
1 check passed
1 check passed
default "Build #638 succeeded on Jenkins"
Details
@alext alext deleted the fix-downtime-previews branch Feb 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.