Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Bootstrap to 3.3.2 and manage analytics via admin gem #369

Merged
merged 3 commits into from Feb 20, 2015
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Feb 12, 2015

  • Upgrade Bootstrap to 3.3.2 (via bootstrap-sass 3.3.3)
    • Includes autoprefixer rails which is a new Bootstrap dependency
  • Include Google analytics managed by gem alphagov/govuk_admin_template#59
    • Remove existing snippet
    • Update analytics usage to match new API

https://github.com/alphagov/govuk_admin_template/blob/master/CHANGELOG.md

fofr added 2 commits Feb 12, 2015
* Upgrade Bootstrap to 3.3.2 (via bootstrap-sass 3.3.3)
  * Includes autoprefixer rails which is a new Bootstrap dependency
* Include Google analytics managed by gem

https://github.com/alphagov/govuk_admin_template/blob/master/CHANGELOG.m
d
* Remove analytics snippet, now provided by gem
* Replace uses of `track` with `trackEvent`
* Use `trackPageview` for tracking tab switches
@fofr fofr force-pushed the bump-admin-gem branch from 1118ac9 to 4f141fc Feb 12, 2015
@bradwright
Copy link
Contributor

@bradwright bradwright commented Feb 16, 2015

Should we roll a new release including alphagov/govuk_admin_template#60?

@fofr
Copy link
Contributor Author

@fofr fofr commented Feb 18, 2015

Yes, definitely.

@benilovj
Copy link
Contributor

@benilovj benilovj commented Feb 18, 2015

Closing while bumping to newer version of govuk_admin_template gem

@benilovj benilovj closed this Feb 18, 2015
This picks up stripping off the last octet of IP addresses before sending them to GA.
@benilovj benilovj reopened this Feb 18, 2015
@benilovj
Copy link
Contributor

@benilovj benilovj commented Feb 18, 2015

I've bumped govuk_admin_template to version 2.1.0, which picks up alphagov/govuk_admin_template#60 .

The rest LGTM 👍

fofr added a commit that referenced this pull request Feb 20, 2015
Upgrade Bootstrap to 3.3.2 and manage analytics via admin gem
@fofr fofr merged commit 4211ca8 into master Feb 20, 2015
1 check passed
1 check passed
default "Build #643 succeeded on Jenkins"
Details
@fofr fofr deleted the bump-admin-gem branch Feb 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.