Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out Linkables with nil titles (eg. redirects) #501

Merged
merged 1 commit into from Sep 13, 2016

Conversation

Projects
None yet
2 participants
@steventux
Copy link
Contributor

steventux commented Sep 13, 2016

https://errbit.publishing.service.gov.uk/apps/5304e0520da11511b0000011/problems/57d7ed6c6578636cf0a40100

Publisher is erroring due to a redirected browse page which now has a nil title. So filter out items with nil titles.

@@ -11,6 +11,7 @@ def stub_linkables
{ base_path: '/browse/tax/vat', internal_name: 'Tax / VAT', publication_state: 'published', content_id: 'CONTENT-ID-VAT' },
{ base_path: '/browse/tax/capital-gains', internal_name: 'Tax / Capital Gains Tax', publication_state: 'published', content_id: 'CONTENT-ID-CAPITAL' },
{ base_path: '/browse/tax/rti', internal_name: 'Tax / RTI', publication_state: 'draft', content_id: 'CONTENT-ID-RTI' },
{ base_path: '/browse/tax/nil', internal_name: nil, publication_state: 'draft', content_id: 'CONTENT-ID-RTI' },

This comment has been minimized.

Copy link
@kevindew

kevindew Sep 13, 2016

Member

probably should switch this content id to be different to line 13

@steventux steventux force-pushed the nil-check-linkables-internal-name branch from 5194e3a to 3e44057 Sep 13, 2016

@steventux steventux merged commit 5ad1a9a into master Sep 13, 2016

1 check passed

default "Build #1277 succeeded on Jenkins"
Details

@steventux steventux deleted the nil-check-linkables-internal-name branch Sep 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.