Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send fact check emails as text not HTML #637

Merged
merged 2 commits into from Aug 9, 2017
Merged

Send fact check emails as text not HTML #637

merged 2 commits into from Aug 9, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Aug 9, 2017

format.text should use render :plain not render :html

Before:

<strong>HTML</strong> Hi,

We need you to check the factual accuracy of changes made to 'Student finance: how to apply' before it’s published on GOV.UK.

After:

Hi,

We need you to check the factual accuracy of changes made to 'Student finance: how to apply' before it’s published on GOV.UK.

Fixes https://govuk.zendesk.com/agent/tickets/2296781

fofr added 2 commits Aug 9, 2017
Be consistent in our use of quotes.
@fofr fofr requested a review from binaryberry Aug 9, 2017
@fofr fofr changed the title Fix html in email Send fact check emails as text not HTML Aug 9, 2017
Copy link
Contributor

@thomasleese thomasleese left a comment

Looks good to me!

@fofr fofr merged commit b1078b6 into master Aug 9, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new vulnerabilities
Details
@fofr fofr deleted the fix-html-in-email branch Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.