Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Candidate deploy view #74

Merged
merged 9 commits into from Jan 28, 2015
Merged

Candidate deploy view #74

merged 9 commits into from Jan 28, 2015

Conversation

@dsingleton
Copy link
Contributor

dsingleton commented Jan 22, 2015

Simplify deployment process by giving you one page with all
the links and information you should need to do a deploy.

  • Navigate to the new view from the list of commits/tags for
    an application
  • See where production is, what release and how old
  • Preview what commits, and authors, this release will contain
    with a link to view the full file diff on github
  • Deep link to the staging/production deploy jobs, prefilling
    the application and release tag
  • Bonus tweaks to some app commit listing UI

Very much minimum viable improvement, it could and will get better.

image

Picking a candidate release:
image
(This isn't very intuitive, but i've got plans to improve this view separately)

David Singleton added 2 commits Jan 21, 2015
We don't need the full hash, the short version will do, and won't
interfer with the rest of the commit information.

Also make it fixed width font for better readability

<main>
<h2>Candidate Release <span class="label label-info"><%= @release_tag %></span></h2>
<p class="lead add-top-margin">Production was deployed to <span class="label label-danger"><%= @production_deploy.version %></span><%= time_ago_in_words(@production_deploy.created_at) %> ago</p>

This comment has been minimized.

@dhwthompson

dhwthompson Jan 22, 2015 Contributor

The phrasing on this feels off: I always think of this as a version being deployed to production, not production being deployed to a version. I would suggest rephrasing this to “release_x was deployed to production n days ago”, but I’m guessing the alignment of the two tags is intentional. Not sure what other options there are.

This comment has been minimized.

@dsingleton

dsingleton Jan 23, 2015 Author Contributor

You're right, that reads badly. Leading with the tag doesn't read quite right either, how about:

Production is release_2156 — deployed at 11:59am on Monday

(I've also changed the date/time format to have more granularity and match the application list.)

@dhwthompson
Copy link
Contributor

dhwthompson commented Jan 22, 2015

From a quick look, I very much like this. I’m next in the office on Tuesday: unless someone else has reviewed and merged it by then, I’ll give it a more thorough review.

@dhwthompson dhwthompson self-assigned this Jan 22, 2015
@dhwthompson
Copy link
Contributor

dhwthompson commented Jan 28, 2015

It doesn’t look like the author images are working at the moment:

Broken author images

This is on preview and on my dev machine: the <img> tags appear to be coming through with an empty src.

@dhwthompson
Copy link
Contributor

dhwthompson commented Jan 28, 2015

When someone writes full, multi-paragraph commit messages (as with more involved applications like Rummager), the list of commits gets very long and unwieldy. Given there’s a link through to the commit page on GitHub, I wonder whether that would be better left out entirely.

David Singleton added 6 commits Jan 21, 2015
Simplify deployment process by giving you one page with all
the links and information you should need to do a deploy.

- Navigate to the new view from the list of commits/tags for
  an application
- See where production is, what release and how old
- Preview what commits, and authors, this release will contain
  with a link to view the full file diff on github
- Deep link to the staging/production deploy jobs, prefilling
  the application and release tag
- Can filter to just merge commits, or by author, or even by hash
- Fix width of the columns so they don't wobble as you filter
- Add link to the commit summary
- Add some other semantic/styling hooks
@dsingleton dsingleton force-pushed the candidate-deploy-view branch from dac1205 to ea6d579 Jan 28, 2015
@dsingleton
Copy link
Contributor Author

dsingleton commented Jan 28, 2015

Comments make sense. I'd be tempted to bring it back in the future as toggle-able, but i'm removing it for now.

Also fixed images, and updated preview.

full commit messages can be long, especially for many changes, taking
up a huge amount of space. as the full commits are available on the
github diff we can probably omit this.
@dsingleton dsingleton force-pushed the candidate-deploy-view branch from 9e6f739 to 3a98e0c Jan 28, 2015
dhwthompson added a commit that referenced this pull request Jan 28, 2015
@dhwthompson dhwthompson merged commit 31b8d01 into master Jan 28, 2015
@dhwthompson dhwthompson deleted the candidate-deploy-view branch Jan 28, 2015
@dhwthompson
Copy link
Contributor

dhwthompson commented Jan 28, 2015

I'd be tempted to bring it back in the future as toggle-able […]

Yup: good idea 👍

@dhwthompson
Copy link
Contributor

dhwthompson commented Jan 28, 2015

This is really nice work, @dsingleton, especially the way it integrates with Jenkins. As one of the people who will be deploying things with it, thank you.

@benilovj
Copy link
Contributor

benilovj commented Jan 30, 2015

@dsingleton really awesome work, just used this for the first time, my deploy was done in about a minute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.