New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Candidate deploy view #74

Merged
merged 9 commits into from Jan 28, 2015

Conversation

Projects
None yet
3 participants
@dsingleton
Contributor

dsingleton commented Jan 22, 2015

Simplify deployment process by giving you one page with all
the links and information you should need to do a deploy.

  • Navigate to the new view from the list of commits/tags for
    an application
  • See where production is, what release and how old
  • Preview what commits, and authors, this release will contain
    with a link to view the full file diff on github
  • Deep link to the staging/production deploy jobs, prefilling
    the application and release tag
  • Bonus tweaks to some app commit listing UI

Very much minimum viable improvement, it could and will get better.

image

Picking a candidate release:
image
(This isn't very intuitive, but i've got plans to improve this view separately)

David Singleton added some commits Jan 21, 2015

David Singleton
Improve rendering of commit hashes in log
We don't need the full hash, the short version will do, and won't
interfer with the rest of the commit information.

Also make it fixed width font for better readability
@fatbusinessman

This comment has been minimized.

Show comment
Hide comment
@fatbusinessman

fatbusinessman Jan 22, 2015

Contributor

From a quick look, I very much like this. I’m next in the office on Tuesday: unless someone else has reviewed and merged it by then, I’ll give it a more thorough review.

Contributor

fatbusinessman commented Jan 22, 2015

From a quick look, I very much like this. I’m next in the office on Tuesday: unless someone else has reviewed and merged it by then, I’ll give it a more thorough review.

@fatbusinessman fatbusinessman self-assigned this Jan 22, 2015

@fatbusinessman

This comment has been minimized.

Show comment
Hide comment
@fatbusinessman

fatbusinessman Jan 28, 2015

Contributor

It doesn’t look like the author images are working at the moment:

Broken author images

This is on preview and on my dev machine: the <img> tags appear to be coming through with an empty src.

Contributor

fatbusinessman commented Jan 28, 2015

It doesn’t look like the author images are working at the moment:

Broken author images

This is on preview and on my dev machine: the <img> tags appear to be coming through with an empty src.

@fatbusinessman

This comment has been minimized.

Show comment
Hide comment
@fatbusinessman

fatbusinessman Jan 28, 2015

Contributor

When someone writes full, multi-paragraph commit messages (as with more involved applications like Rummager), the list of commits gets very long and unwieldy. Given there’s a link through to the commit page on GitHub, I wonder whether that would be better left out entirely.

Contributor

fatbusinessman commented Jan 28, 2015

When someone writes full, multi-paragraph commit messages (as with more involved applications like Rummager), the list of commits gets very long and unwieldy. Given there’s a link through to the commit page on GitHub, I wonder whether that would be better left out entirely.

David Singleton added some commits Jan 21, 2015

David Singleton
Add a 'candidate release' view, to be using during deployment
Simplify deployment process by giving you one page with all
the links and information you should need to do a deploy.

- Navigate to the new view from the list of commits/tags for
  an application
- See where production is, what release and how old
- Preview what commits, and authors, this release will contain
  with a link to view the full file diff on github
- Deep link to the staging/production deploy jobs, prefilling
  the application and release tag
David Singleton
Add filtering for commits table
- Can filter to just merge commits, or by author, or even by hash
- Fix width of the columns so they don't wobble as you filter
David Singleton
Add date information to release diff commit view
- Add link to the commit summary
- Add some other semantic/styling hooks
@dsingleton

This comment has been minimized.

Show comment
Hide comment
@dsingleton

dsingleton Jan 28, 2015

Contributor

Comments make sense. I'd be tempted to bring it back in the future as toggle-able, but i'm removing it for now.

Also fixed images, and updated preview.

Contributor

dsingleton commented Jan 28, 2015

Comments make sense. I'd be tempted to bring it back in the future as toggle-able, but i'm removing it for now.

Also fixed images, and updated preview.

David Singleton
Remove commit body, fix images
full commit messages can be long, especially for many changes, taking
up a huge amount of space. as the full commits are available on the
github diff we can probably omit this.

fatbusinessman added a commit that referenced this pull request Jan 28, 2015

@fatbusinessman fatbusinessman merged commit 31b8d01 into master Jan 28, 2015

@fatbusinessman fatbusinessman deleted the candidate-deploy-view branch Jan 28, 2015

@fatbusinessman

This comment has been minimized.

Show comment
Hide comment
@fatbusinessman

fatbusinessman Jan 28, 2015

Contributor

I'd be tempted to bring it back in the future as toggle-able […]

Yup: good idea 👍

Contributor

fatbusinessman commented Jan 28, 2015

I'd be tempted to bring it back in the future as toggle-able […]

Yup: good idea 👍

@fatbusinessman

This comment has been minimized.

Show comment
Hide comment
@fatbusinessman

fatbusinessman Jan 28, 2015

Contributor

This is really nice work, @dsingleton, especially the way it integrates with Jenkins. As one of the people who will be deploying things with it, thank you.

Contributor

fatbusinessman commented Jan 28, 2015

This is really nice work, @dsingleton, especially the way it integrates with Jenkins. As one of the people who will be deploying things with it, thank you.

@benilovj

This comment has been minimized.

Show comment
Hide comment
@benilovj

benilovj Jan 30, 2015

Contributor

@dsingleton really awesome work, just used this for the first time, my deploy was done in about a minute!

Contributor

benilovj commented Jan 30, 2015

@dsingleton really awesome work, just used this for the first time, my deploy was done in about a minute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment