Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete CI provider config files and gems we don't use #144

Merged
merged 1 commit into from Feb 10, 2020

Conversation

@issyl0
Copy link
Member

issyl0 commented Feb 7, 2020

  • Since this was unforked from binaryberry/seal, we don't need to maintain the following:
    • .rvmrc because we use rbenv and .ruby-version.
    • Guardfile as we can just as well run the tests ourselves, given
      what little development we do on this app.
    • .travis.yml as (slightly regrettably) we run the tests on Jenkins.
- Since this was [unforked](#139)
  from binaryberry/seal, we don't need to maintain the following:
  - `.rvmrc` because we use `rbenv` and `.ruby-version`.
  - `Guardfile` as we can just as well run the tests ourselves, given
    what little development we do on this app.
  - `.travis.yml` as (slightly regrettably) we run the tests on Jenkins.
@issyl0 issyl0 merged commit 08ffcd9 into master Feb 10, 2020
1 check passed
1 check passed
continuous-integration/jenkins/branch This commit looks good
Details
@issyl0 issyl0 deleted the delete-ci-providers-and-files-we-dont-use branch Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.