Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specific facets to use the new checkbox filter feature #1452

Merged
merged 1 commit into from Mar 8, 2019

Conversation

Projects
None yet
2 participants
@aliuk2012
Copy link
Contributor

aliuk2012 commented Mar 7, 2019

The new key added to the facets will control whether user see a filter textfield as shown in image below

image

Ticket: https://trello.com/c/sEGGP7dF/470-turn-on-option-select-filters-for-finders

@aliuk2012 aliuk2012 force-pushed the add-filters-to-option-select branch from b898203 to eb995c7 Mar 7, 2019

@aliuk2012 aliuk2012 force-pushed the add-filters-to-option-select branch from eb995c7 to 8d36b3b Mar 7, 2019

@aliuk2012 aliuk2012 marked this pull request as ready for review Mar 8, 2019

@bilbof

bilbof approved these changes Mar 8, 2019

Copy link
Contributor

bilbof left a comment

LGTM

@aliuk2012 aliuk2012 merged commit b14c567 into master Mar 8, 2019

2 checks passed

continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/publishing-e2e-tests Publishing end-to-end tests succeeded on Jenkins
Details

@aliuk2012 aliuk2012 deleted the add-filters-to-option-select branch Mar 8, 2019

aliuk2012 added a commit that referenced this pull request Mar 11, 2019

Add filter option to two facets on all_content finder
Two facets were missed off the original PR #1452

aliuk2012 added a commit that referenced this pull request Mar 12, 2019

Add filter option to people facet on news & comms finder
People facet `show_option_select_filter` key was missed off the original
PR #1452
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.