Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn /search/advanced into a special route #1972

Merged
merged 1 commit into from Feb 10, 2020
Merged

Conversation

@barrucadu
Copy link
Contributor

barrucadu commented Feb 10, 2020

We don't use this finder any more, finder-frontend redirects it to
some other finder:
https://github.com/alphagov/finder-frontend/blob/master/app/controllers/redirection_controller.rb#L33

We still need the route, so put it in the SpecialRoutePublisher
instead.

@huwd

This comment has been minimized.

Copy link
Contributor

huwd commented Feb 10, 2020

@barrucadu barrucadu force-pushed the msw/advanced-search branch from ae7ad93 to 04b7855 Feb 10, 2020
@huwd

This comment has been minimized.

Copy link
Contributor

huwd commented Feb 10, 2020

We don't use this finder any more, finder-frontend redirects it to
some other finder:
https://github.com/alphagov/finder-frontend/blob/master/app/controllers/redirection_controller.rb#L33

We still need the route, so put it in the SpecialRoutePublisher
instead.
@barrucadu

This comment has been minimized.

Copy link
Contributor Author

barrucadu commented Feb 10, 2020

I'll remove the line about advanced search there, but I'll leave the brexit one as the config file is still there (even though it does redirect at the moment)

@barrucadu barrucadu force-pushed the msw/advanced-search branch from 04b7855 to 5af4254 Feb 10, 2020
@huwd
huwd approved these changes Feb 10, 2020
@barrucadu barrucadu merged commit da351d0 into master Feb 10, 2020
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/publishing-e2e-tests Publishing end-to-end tests succeeded on Jenkins
Details
@barrucadu barrucadu deleted the msw/advanced-search branch Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.