Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Switch to using govuk_admin_template #241
Testing with IE7 (~6% of all sessions), there are some alignment issues with forms, and the glyphicon font doesn't work. The extent of my planned fix for this is to ensure that sign on, change password and edit your account pages work acceptably in IE7. (IE6 has 0.18% of all sessions)
* `top-buffer` is a duplicate of a margin helper class provided by the govuk_admin_template
* Add bootstrap 3 form classes * Bootstrap 3 form ‘add-ons’ behave differently, you can’t toggle the display on and off so easily. Instead show a greyed out ‘ok’ sign, which is replaced with a green or red symbol depending on input * Render help text in an alert, and remove icons for better legibility * Use friendlier green and red colours for ok/not-ok symbols
* Refer to fixed git branch of alphabetical_paginate in gem file * Pull request outstanding: lingz/alphabetical_paginate#23 * There’s an unclosed <ul> which causes incorrect nesting, and warning when tests run.
Updated to latest version of admin gem for better Bootstrap 3 styling in IE7. Cross browser good to go now.
Also used latest admin gem input classes (
@bishboria I've fixed the rendering problems you were seeing in Firefox if you could re-check.