Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jasmine for Javascript testing #244

Merged
merged 4 commits into from Jul 18, 2014
Merged

Add Jasmine for Javascript testing #244

merged 4 commits into from Jul 18, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jul 11, 2014

  • Configure to avoid default phantomjs download
  • Run javascript tests by default
  • Include govuk-admin-template as jasmine src file

Password strength indicator needs a javascript spec, but the work to produce that is quite large, and should be separate to this pull request.

fofr added 3 commits Jul 11, 2014
* Run `rails g jasmine:install`
* Configure to avoid default phantomjs download
* Run javascript tests by default
* Required for bootstrap and jquery libraries to be present
@dhwthompson
Copy link
Contributor

@dhwthompson dhwthompson commented Jul 15, 2014

I agree that testing the password strength indicator is beyond the scope of this pull request, but I figured it would be useful to have a placeholder test just to make sure Jasmine is configured properly. I added one in ec6788e and pushed it to another branch: what do you think?

@fofr
Copy link
Contributor Author

@fofr fofr commented Jul 15, 2014

👍 Good to have an example to work from.

* Start chosen select drop downs based on data attributes rather than
CSS classes
@fofr
Copy link
Contributor Author

@fofr fofr commented Jul 17, 2014

@fatbusinessman Added a module and tests in 4d21227

dhwthompson added a commit that referenced this pull request Jul 18, 2014
Add Jasmine for Javascript testing
@dhwthompson dhwthompson merged commit a2b3326 into master Jul 18, 2014
1 check passed
1 check passed
default "Build #287 succeeded on Jenkins"
Details
@dhwthompson dhwthompson deleted the jasmine branch Jul 18, 2014
ChrisBAshton added a commit that referenced this pull request Sep 15, 2020
This was added over 6 years ago:
04e34a8#diff-54dc43b93174691dc226df624651d227R1-R4

We explicitly stopped PhantomJS from being downloaded, to use the
PhantomJS that is already on the PATH. But it's not clear why we
did this (nor is it clear from the PR description in #244).

It's been working fine, but recently the CI build has broken,
whereas the same code works fine in Docker. So the less environmental
manipulation we brittly rely on, the better.

Using the PhantomJS included with Jasmine seems to fix the build,
so we no longer need the helper file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.