Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
I agree that testing the password strength indicator is beyond the scope of this pull request, but I figured it would be useful to have a placeholder test just to make sure Jasmine is configured properly. I added one in ec6788e and pushed it to another branch: what do you think?
This was added over 6 years ago: 04e34a8#diff-54dc43b93174691dc226df624651d227R1-R4 We explicitly stopped PhantomJS from being downloaded, to use the PhantomJS that is already on the PATH. But it's not clear why we did this (nor is it clear from the PR description in #244). It's been working fine, but recently the CI build has broken, whereas the same code works fine in Docker. So the less environmental manipulation we brittly rely on, the better. Using the PhantomJS included with Jasmine seems to fix the build, so we no longer need the helper file.