Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up logged-out change email form #274

Merged
merged 1 commit into from Oct 7, 2014
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Oct 6, 2014

Change email form was missing default Bootstrap classes, meaning disabled fields didn’t look disabled, labels weren’t above fields and fields were the wrong size.

  • Add bootstrap classes
  • Keep page title and h1 consistent
  • Move warning message out of well to avoid nesting
  • Stop nested labels around passphrase field

Before:
screen shot 2014-10-06 at 11 13 23

After:
screen shot 2014-10-06 at 11 45 13

Change email form was missing default Bootstrap classes, meaning
disabled fields didn’t look disabled, labels weren’t above fields and
fields were the wrong size.

* Add bootstrap classes
* Keep page title and h1 consistent
* Move warning message out of well to avoid nesting
* Stop nested labels around passphrase field
@fofr fofr force-pushed the change-email-style-fix branch from cdec788 to 9aa2061 Oct 6, 2014
vinayvinay added a commit that referenced this pull request Oct 7, 2014
Clean up logged-out change email form
@vinayvinay vinayvinay merged commit a97bf18 into master Oct 7, 2014
1 check passed
1 check passed
default "Build #383 succeeded on Jenkins"
Details
@vinayvinay vinayvinay deleted the change-email-style-fix branch Oct 7, 2014
@vinayvinay
Copy link
Contributor

@vinayvinay vinayvinay commented Oct 7, 2014

I had written-up a card for this task: https://www.agileplannerapp.com/boards/173808/cards/5582. I've moved it to Current Iteration, so that we can use it to track deployments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.