Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup change email form when there's a pending change #275

Merged
merged 2 commits into from Oct 13, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Oct 13, 2014

  • Add missing Bootstrap 3 classes
  • Move cancel and resend buttons beneath form field
  • Visually separate the change email form and the resend email form
  • Improve re-sent email copy

Before:
screen shot 2014-10-13 at 11 23 18

After:
screen shot 2014-10-13 at 11 23 45

fofr added 2 commits Oct 13, 2014
* Add missing Bootstrap 3 classes
* Move cancel and resend buttons beneath form field
* Visually separate the change email form and the resend email form
“Successfully resent email change email” is a bit of a mouthful. Also,
resent is not re-sent.
@fofr fofr force-pushed the pending-email-change-form branch from d8d736f to 4738de4 Oct 13, 2014
danielroseman added a commit that referenced this pull request Oct 13, 2014
Cleanup change email form when there's a pending change
@danielroseman danielroseman merged commit a4c4c4e into master Oct 13, 2014
1 check passed
1 check passed
default "Build #385 succeeded on Jenkins"
Details
@danielroseman danielroseman deleted the pending-email-change-form branch Oct 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.