Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sass to 3.4 and fix glyphicons #370

Merged
merged 1 commit into from Jun 18, 2015
Merged

Bump sass to 3.4 and fix glyphicons #370

merged 1 commit into from Jun 18, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jun 18, 2015

  • Avoid using old sass version
  • Avoid problems with sass 3.2.19 and bootstrap-sass 3.3.5
    (alphagov/govuk_admin_template#70)
  • Update to the latest version of sass, 3.4 so that the bootstrap sass
    compiles correctly and the glyphicons load

cc @jennyd @jamiecobbett

* Avoid using 2 year old sass version
* Avoid problems with sass 3.2.19 and bootstrap-sass 3.3.5
(alphagov/govuk_admin_template#70)
* Update to the latest version of sass, 3.4 so that the bootstrap sass
compiles correctly and the glyphicons load
boffbowsh added a commit that referenced this pull request Jun 18, 2015
Bump sass to 3.4 and fix glyphicons
@boffbowsh boffbowsh merged commit aed861a into master Jun 18, 2015
2 checks passed
2 checks passed
Test signon changes against gds-sso master "Testing gds-sso against changes #26 succeeded on Jenkins"
Details
default "Build #646 succeeded on Jenkins"
Details
@boffbowsh boffbowsh deleted the bump-sass branch Jun 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.