Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve design and copy for setting up 2-step #397

merged 5 commits into from Sep 11, 2015

Improve design and copy for setting up 2-step #397

merged 5 commits into from Sep 11, 2015


Copy link

@fofr fofr commented Sep 11, 2015

  • Disable autocomplete for 2SV code fields
  • Revise copy for 2-step verification based on content crit
  • Remove remaining prototype front-end code, general clean up
  • Switch to a darker panel design for better content contrast
  • Improve error handling when incorrect codes are added during set up

cc @boffbowsh @benilovj

screen shot 2015-09-11 at 16 09 17

screen shot 2015-09-11 at 16 09 23

screen shot 2015-09-11 at 16 09 10

screen shot 2015-09-11 at 16 16 26

fofr added 5 commits Sep 11, 2015
* Include clear purpose of 2-step verification
* Install rather than download app
* Use correct Windows app name
* Replace QR code with barcode to match copy used in authenticator apps
* Remove numbers from steps
* Clarify that the last step in set up is the final one by updating the
button text – and to remind users they are still in the set up phase
Remove code copied from prototype
* Make the important content clearer
* Left align barcode
* Use darker parts styles as used in publisher
When the verification code is wrong at setup, return the user to that
field with an appropriate error message.

* Return a 422 status
* Close the top panel, open the bottom one
* Add error status around form fields
* Correctly close `form_tag`
* Remove empty wrapping class
boffbowsh added a commit that referenced this pull request Sep 11, 2015
Improve design and copy for setting up 2-step
@boffbowsh boffbowsh merged commit 55af149 into master Sep 11, 2015
2 checks passed
2 checks passed
Test signon changes against gds-sso master "Testing gds-sso against changes #138 succeeded on Jenkins"
default "Build #752 succeeded on Jenkins"
@boffbowsh boffbowsh deleted the 2sv-copy-tweaks branch Sep 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.