Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redact email addresses from analytics #411

Merged
merged 2 commits into from Oct 5, 2015
Merged

Redact email addresses from analytics #411

merged 2 commits into from Oct 5, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Oct 5, 2015

https://trello.com/c/kEt8UXfz/129-personally-identifiable-information-in-google-analytics-medium

Don’t pass user email address to Google Analytics. Replace with “[email]”. This is the same pattern as used by the Support app.

Update a single flash message to use emails rather than names to

  • be consistent with other flash messages
  • allow personal information to be redaction
  • make it easier for a user to follow up with a message to the suspended/unsuspended user
fofr added 2 commits Oct 5, 2015
Don’t pass user email address to Google Analytics. Replace with
“[email]”. This is the same pattern as used by the Support app.
* Be consistent with all other flash messages which use email addresses
rather than user names
* Personal information in this flash message will be redacted when sent
to analytics
* An email address is more useful if the user wishes to follow up with
a message to that user
jamiecobbett added a commit that referenced this pull request Oct 5, 2015
Redact email addresses from analytics
@jamiecobbett jamiecobbett merged commit 46d48f8 into master Oct 5, 2015
2 checks passed
2 checks passed
Test signon changes against gds-sso master "Testing gds-sso against changes #185 succeeded on Jenkins"
Details
default "Build #797 succeeded on Jenkins"
Details
@jamiecobbett jamiecobbett deleted the fix-analytics-pii branch Oct 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.