Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `o-tron` references from readme #423

Merged
merged 1 commit into from Oct 15, 2015
Merged

Remove `o-tron` references from readme #423

merged 1 commit into from Oct 15, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Oct 15, 2015

We call the app “Signon” (one word, no hyphens at the moment).

README.md Outdated
@@ -13,8 +13,7 @@ Details of our interpretation of OAuth are provided in

The application has Rake tasks to create new users and client applications.

To create a new client application to which Sign-on-o-Tron will provide sign-on
services:
To create a new client application which will provide sign-on services:

This comment has been minimized.

@alext

alext Oct 15, 2015
Contributor

This new wording isn't quite correct. It's suggesting that the client application will provide the sign-on services, when it's actually this application that provides them, and the client application uses them.

This comment has been minimized.

@fofr

fofr Oct 15, 2015
Author Contributor

Whoops. Fixed.

@alext
Copy link
Contributor

@alext alext commented Oct 15, 2015

One small comment on the wording, otherwise this looks good to me. I'm looking forward to the point where we can rename this repo.

We call the app “Signon” (one word, no hyphens at the moment).
@fofr fofr force-pushed the readme-tweak branch from fd4a545 to 61f413e Oct 15, 2015
jamiecobbett added a commit that referenced this pull request Oct 15, 2015
Remove `o-tron` references from readme
@jamiecobbett jamiecobbett merged commit 0bc5426 into master Oct 15, 2015
2 checks passed
2 checks passed
Test signon changes against gds-sso master "Testing gds-sso against changes #233 succeeded on Jenkins"
Details
default "Build #844 succeeded on Jenkins"
Details
@jamiecobbett jamiecobbett deleted the readme-tweak branch Oct 15, 2015
@matthewford

This comment has been minimized.

Copy link
Contributor

@matthewford matthewford commented on 61f413e Jan 14, 2016

can we rename the repo too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.