Add a UI to add supported permissions to an application #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this reminds us that we need to have a conversation about a possible permission naming convention and needing finer grained permissions ourselves in sign on so that this functionality isn't open to everyone. |
| end | ||
| end | ||
|
|
||
| context "GET create" do |
There was a problem hiding this comment.
This should be "POST create"
* GET create -> POST create * Only do a single request in the test
mnowster
added a commit
that referenced
this pull request
Jan 15, 2013
Add a UI to add supported permissions to an application
gpeng
pushed a commit
that referenced
this pull request
Nov 29, 2017
Fix creation of dummy API user in test mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimum changes to allow us to add a new permission when we add an authority to licensing. Which means no editing/deletion of permissions.