Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump admin gem to 4.0.1 #458

Merged
merged 2 commits into from Jan 12, 2016
Merged

Bump admin gem to 4.0.1 #458

merged 2 commits into from Jan 12, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Dec 31, 2015

  • Allow environment_style to be set to integration
  • Use admin template config for app title

Some of the earlier dependencies on environment_style were refactored out in #444

cc @boffbowsh

fofr added 2 commits Dec 31, 2015
Allow environment_style to be set to integration.
@@ -1,4 +1,3 @@
<% content_for :app_title, 'GOV.UK Signon' %>
<% content_for :page_title, "#{yield(:title)} | GOV.UK Signon" %>

This comment has been minimized.

@benilovj

benilovj Dec 31, 2015
Contributor

Should the page title still have the app name?

This comment has been minimized.

@fofr

fofr Dec 31, 2015
Author Contributor

At the moment there isn't a pattern for doing this automatically. But I think there should be.

This comment has been minimized.

@benlovell

benlovell Jan 6, 2016
Contributor

@fofr will you act on this or should we get this merged?

This comment has been minimized.

@fofr

fofr Jan 6, 2016
Author Contributor

I wasn't going to alter it as part of this PR. I think it's something that's needed in the admin template itself.

benilovj added a commit that referenced this pull request Jan 12, 2016
Bump admin gem to 4.0.1
@benilovj benilovj merged commit e6f27d2 into master Jan 12, 2016
2 checks passed
2 checks passed
Test signon changes against gds-sso master "Testing gds-sso against changes #383 succeeded on Jenkins"
Details
default "Build #977 succeeded on Jenkins"
Details
@benilovj benilovj deleted the bump-admin-gem branch Jan 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.