Skip to content
Commits on Apr 7, 2016
  1. @boffbowsh

    Merge pull request #143 from chrisroos/rescue-ssl-errors-in-load-temp…

    …late
    
    Rescue SSL errors in Skin#load_template
    boffbowsh committed Apr 7, 2016
  2. @chrisroos
  3. @chrisroos

    Rescue SSLError in Skin#load_template

    I've seen this problem a few times in development and at least once in
    Smart Answers production[1]. It happens when the connection to the
    assets server fails because of an SSL problem.
    
    I used cURL to make the request when I experienced this problem in
    development:
    
        $ curl -v \
        https://assets-origin.integration.publishing.service.gov.uk/templates/wrapper.html.erb
        *   Trying 31.210.245.98...
        * Connected to
        * assets-origin.integration.publishing.service.gov.uk
        * (31.210.245.98) port 443 (#0)
        * Server aborted the SSL handshake
        * Closing connection 0
        curl: (35) Server aborted the SSL handshake
        Trying to connect to assets server using cURL gives this information:
    
    [1]:
    https://errbit.publishing.service.gov.uk/apps/533c35ae0da1159384044f5f/problems/56e7a162657863326adf0600
    chrisroos committed Apr 7, 2016
Commits on Feb 22, 2016
  1. @dsingleton

    Merge pull request #141 from alphagov/bump-version

    Version 9.1.0
    dsingleton committed Feb 22, 2016
  2. @fofr

    Version 9.1.0

    * Allow applications to request components using full or partial
    component paths, eg "name", "name.raw" and "name.raw.html.erb". This
    allows components to be nested within other components.
    
    #140
    fofr committed Feb 22, 2016
  3. @benlovell

    Merge pull request #140 from alphagov/more-flexible-component-loading

    Accept full and partial component paths in resolver
    benlovell committed Feb 22, 2016
  4. @fofr

    Accept full and partial component paths

    For components to be able to call other components from within
    (composeable components) they need to use a component path that
    includes `.raw` (this is not a standard Rails format, but a convention
    we use).
    fofr committed Feb 22, 2016
Commits on Jan 26, 2016
  1. @dsingleton

    Merge pull request #139 from alphagov/bump-version-9.0.1

    Release version 9.0.1
    dsingleton committed Jan 26, 2016
  2. @boffbowsh

    Release version 9.0.1

    Bump govuk-lint to pin rubocop so it doesn't complain
    about the unfrozen version number
    boffbowsh committed Jan 26, 2016
  3. @dsingleton

    Merge pull request #138 from alphagov/rails-sec-releases-compat

    Add optional arg to template resolver call
    dsingleton committed Jan 26, 2016
  4. @boffbowsh

    Add optional arg to template resolver call

    CVE-2016-0752 was announced, the fix for which changed how Rails calls
    template resolvers. It added an optional argument (defaulting to false)
    which controls whether the template resolver should find templates
    outside `Rails.root`. In Slimmer’s case, we take any requested
    templates with a prefix of `govuk_component`and resolve them with the
    static service over HTTP. The local file system is never touched.
    Therefore, it’s safe to simply add the new argument here but ignore it
    and carry on as normal.
    boffbowsh committed Jan 26, 2016
Commits on Aug 25, 2015
  1. @tommyp

    Merge pull request #137 from alphagov/bump-version

    Bump version to 9.0.0
    tommyp committed Aug 25, 2015
  2. @edds

    Bump version to 9.0.0

    edds committed Aug 25, 2015
  3. @dsingleton

    Merge pull request #136 from alphagov/new-default

    Set the default template to be core_layout
    dsingleton committed Aug 25, 2015
Commits on Aug 24, 2015
  1. @edds

    Set the default template to be core_layout

    So that we can migrate off the current `wrapper` layout change the
    default template to be `core_layout`. All existing apps will need to be
    updated to explicitly call wrapper if they were previously just relying
    on that being the default.
    edds committed Aug 24, 2015
Commits on Jul 28, 2015
  1. @jamiecobbett

    Merge pull request #134 from alphagov/govuk-lint

    Run GOV.UK ruby linter as part of CI builds
    jamiecobbett committed Jul 28, 2015
Commits on Jul 27, 2015
  1. @fofr

    Merge pull request #135 from alphagov/release-8.4.0

    Version 8.4.0
    fofr committed Jul 27, 2015
  2. @dsingleton

    Release version 8.4.0

    * Add support for moving `meta` tags that use `property` attribute
    
      Previously only meta tags using the `name` attribute were moved into the
      `head` of the page. This allows OpenGraph-style meta tags to be included
      by an application using Slimmer.
    dsingleton committed Jul 27, 2015
Commits on Jul 24, 2015
  1. @dsingleton

    Run GOV.UK ruby linter as part of CI builds

    It's configured to only report on the diff of changes, not the whole repo.
    
    I've run it against the whole repo and there a reasonable amount of violations,
    and bulk fixing them is usually contentious, so i'm ignoring that for now.
    
    With this linting in place at least nothing new will violate the style guide
    and hopefully this will mean computers can give the feedback on style issues,
    rather humans, which computers are better at and avoids humans having to give
    nitpick-y feedback.
    dsingleton committed Jul 24, 2015
  2. @dsingleton

    Merge pull request #133 from dringtech/tag-mover-supports-property

    Copying meta tags with property
    dsingleton committed Jul 24, 2015
  3. @gilesdring

    Copying meta tags with property

    Previously, slimmer skipped meta tags with no name set, which dropped
    OpenGraph and Twitter meta tags. This now separately copies these
    over.
    
    Also adding tests for meta tag with property and test for duplicate property meta tags
    gilesdring committed Jul 22, 2015
Commits on Jun 26, 2015
  1. @fofr

    Merge pull request #131 from alphagov/version_8_3

    Bump to version 8.3.0.
    fofr committed Jun 26, 2015
  2. @danielroseman

    Bump to version 8.3.0.

    Adds support for 403 error page.
    danielroseman committed Jun 26, 2015
  3. @bradwright

    Merge pull request #130 from alphagov/403_error

    Add support for 403 error page.
    bradwright committed Jun 26, 2015
  4. @danielroseman
Commits on Jun 2, 2015
  1. @alext

    Merge pull request #129 from alphagov/bump-version

    Bump to 8.2.1
    alext committed Jun 2, 2015
  2. @edds

    Bump to 8.2.1

    Update rendering app meta tag to use GOVUK_APP_NAME env variable if
    available
    edds committed Jun 2, 2015
  3. @alext

    Merge pull request #128 from alphagov/use-env-variable

    Use GOVUK_APP_NAME if it is set
    alext committed Jun 2, 2015
  4. @edds

    Use GOVUK_APP_NAME if it is set

    Rather than using the applications class name use the GOVU_APP_NAME
    environment variable if it is around. This will then better match the
    names we use within the infrastructure, and also match the vhost
    name.
    edds committed Jun 2, 2015
Commits on May 29, 2015
  1. @fofr

    Merge pull request #127 from alphagov/version-bump

    Bump version to 8.2.0
    fofr committed May 29, 2015
  2. @edds

    Bump version to 8.2.0

    Adds meta tag with current application name
    edds committed May 29, 2015
  3. @evilstreak

    Merge pull request #126 from alphagov/rendering-application

    Output rendering application in meta tag
    evilstreak committed May 29, 2015
  4. @edds

    Output rendering application in meta tag

    It would be really useful to be able to segment analytics by rendering
    application. It would let us have things like JavaScript errors per
    application and page timings per application.
    
    This change takes the class name of the currently running application
    and adds it as a meta tag which can then be read by JavaScript.
    edds committed May 28, 2015
Commits on Mar 17, 2015
  1. @dsingleton

    Merge pull request #116 from alphagov/improve_testing_component_docum…

    …entation
    
    Improve the documentation for testing components
    dsingleton committed Mar 17, 2015
Commits on Mar 16, 2015
  1. @dsingleton

    Merge pull request #123 from alphagov/bump-version

    Bump version to 8.1.0
    dsingleton committed Mar 16, 2015
Something went wrong with that request. Please try again.