Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webmock only listed as development dependency #201

Closed
fofr opened this issue Jul 19, 2017 · 1 comment
Closed

Webmock only listed as development dependency #201

fofr opened this issue Jul 19, 2017 · 1 comment

Comments

@fofr
Copy link
Contributor

fofr commented Jul 19, 2017

We require webmock in the component test helpers here:

slimmer/lib/slimmer/test_helpers/govuk_components.rb

Line 1 in 4763163

require 'webmock'

This gets included when a host application loads the slimmer test helpers:
https://github.com/alphagov/slimmer#rspec

slimmer/lib/slimmer/rspec.rb

Line 5 in 4763163

require 'slimmer/test_helpers/govuk_components'

But we only define webmock as a development dependency:

slimmer/slimmer.gemspec

Line 33 in 4763163

s.add_development_dependency 'webmock', '1.18.0'

A host application without webmock errors with:

active_support/dependencies.rb:293:in `require': cannot load such file -- webmock (LoadError)
fofr added a commit to alphagov/govuk_publishing_components that referenced this issue Jul 19, 2017
@fofr
Load slimmer test helpers
752ee4d 
Add webmock dependency and require webmock as it does not come with
Slimmer.

Issue raised here:
alphagov/slimmer#201
@tijmenb
Copy link
Contributor

tijmenb commented Mar 27, 2018

I suppose this is no longer a problem with the coupling of slimmer and govuk_publishing_components?

@tijmenb tijmenb closed this as completed Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tijmenb @fofr