Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error so pages are not cached #202

Merged
merged 1 commit into from Aug 14, 2017
Merged

Raise error so pages are not cached #202

merged 1 commit into from Aug 14, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Aug 14, 2017

When the body inserter fails, the page errors but the resulting error
gets cached. This means the cached error pages gets seen by users.

Raise error to avoid caching an incorrect page.

(We're pointing government-frontend at this branch here: alphagov/government-frontend#445)

When the body inserter fails, the page errors but the resulting error
gets cached. This means the cached error pages gets seen by users.

Raise error to avoid caching an incorrect page.
@boffbowsh
Copy link
Contributor

@boffbowsh boffbowsh commented Aug 14, 2017

👍

@tijmenb
Copy link
Contributor

@tijmenb tijmenb commented Aug 14, 2017

Should we remove the entire rescue block? I think this might cause the errors to be reported to Airbrake twice. (This would also help with moving to Sentry btw)

@fofr fofr changed the title [Do not merge] Raise error so pages are not cached Raise error so pages are not cached Aug 14, 2017
@fofr fofr merged commit ecabda0 into master Aug 14, 2017
1 check failed
1 check failed
continuous-integration/jenkins/branch This commit cannot be built
Details
@barrucadu barrucadu deleted the raise-error branch Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.