Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
An attempt at fixing intermittent test failure #1816
This error has been occurring intermittently, but annoyingly regularly,
See #1624 for more details.
I've seen the error happen on my local machine and it got to a point yesterday
When the error occurred, I noticed it seemed to always coincide with a JSON
However, there was never any mention of an exception or a stack trace. So I
The exception made it look as if the
In reading the
Although I can't say for sure that this fixes the problem or exactly how it
How were you running this? I've just tried running it a number of times using
@chrisroos: That's how I was running it too. After a while I disabled the non-JS versions of the tests by commenting out the relevant lines of the
My hypothesis is that the problem is some kind of timing/race condition, so I'm not surprised that you didn't see the problem. I suspect I was just lucky (?) that the problem was occurring reasonably regularly on my local machine yesterday.
My main reason for submitting this PR was to see whether (a) anyone understood more about WebMock's
What do people think about merging this to see whether it stops the intermittent build failures on CI?