New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rubocop with govuk-lint #1901

Merged
merged 2 commits into from Aug 24, 2015

Conversation

Projects
None yet
2 participants
@chrisroos
Contributor

chrisroos commented Aug 20, 2015

This Pull Request:

  • Removes the Rubocop config files (.rubocop.yml and .disabled-rubocop.yml) from our repo
  • Removes the "rubocop" Gem from our Gemfile
  • Adds the "govuk-lint" Gem to our Gemfile

The "govuk-lint" Gem contains both Rubocop and a number of Cops that help enforce the GOV.UK Styleguide.

We weren't actively using Rubocop so I'm hoping this'll be a fairly uncontroversial change. Assuming this is OK, I'll open another PR to get govuk-lint-ruby added to jenkins.sh and Rake.

@floehopper

This comment has been minimized.

Show comment
Hide comment
@floehopper

floehopper Aug 20, 2015

Contributor

LGTM 👍

Contributor

floehopper commented Aug 20, 2015

LGTM 👍

chrisroos added some commits Aug 20, 2015

Remove Rubocop config files
In preparation for replacing the rubocop Gem with the govuk-lint Gem, which
includes Cops for the GOVUK Styleguide.

These config files were introduced in 0db1de5.
Replace rubocop with govuk-lint
The govuk-lint Gem includes Rubocop along with a number of Cops that match the
GOVUK Styleguides.

@chrisroos chrisroos merged commit cb1c458 into master Aug 24, 2015

1 check passed

default "Build #2773 succeeded on Jenkins"
Details

chrisroos added a commit that referenced this pull request Aug 24, 2015

Merge branch 'replace-rubocop-with-govuk-lint'
PR #1901.

This branch:

* Removes the Rubocop config files (.rubocop.yml and .disabled-rubocop.yml)
from our repo

* Removes the "rubocop" Gem from our Gemfile

* Adds the "govuk-lint" Gem to our Gemfile

The "govuk-lint" Gem contains both Rubocop and a number of Cops that help
enforce the GOV.UK Styleguide.

We weren't actively using Rubocop so I'm not worried that we're losing anything
by replacing it with govuk-lint.

I'll open another PR to get govuk-lint-ruby added to jenkins.sh and Rake.

@chrisroos chrisroos deleted the replace-rubocop-with-govuk-lint branch Aug 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment