New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update checksum data for redundancy smart answers #2004

Merged
merged 2 commits into from Oct 14, 2015

Conversation

Projects
None yet
2 participants
@chrisroos
Contributor

chrisroos commented Oct 13, 2015

I made a change to redundancy_pay.rb in another branch and was surprised not to have to update the checksum data. I realised that it was because the checksum data didn't include the redundancy_pay shared logic.

This branch rectifies that.

Expected user-visible changes

  • None.
@floehopper

This comment has been minimized.

Show comment
Hide comment
@floehopper

floehopper Oct 13, 2015

Contributor

LGTM 👍

Contributor

floehopper commented Oct 13, 2015

LGTM 👍

chrisroos added some commits Oct 13, 2015

Update calculate-employee-redundancy-pay-files.yml
I noticed that the checksum data didn't include the redundancy_pay.rb shared
logic.

Updated using:

    $ rails r script/generate-checksums-for-smart-answer.rb \
    calculate-employee-redundancy-pay \
    lib/smart_answer_flows/shared_logic/redundancy_pay.rb
Update calculate-your-redundancy-pay-files.yml
I noticed that the checksum data didn't include the redundancy_pay.rb shared
logic.

Updated using:

    $ rails r script/generate-checksums-for-smart-answer.rb \
    calculate-your-redundancy-pay \
    lib/smart_answer_flows/shared_logic/redundancy_pay.rb
@chrisroos

This comment has been minimized.

Show comment
Hide comment
@chrisroos

chrisroos Oct 14, 2015

Contributor

I've rebased on master and force pushed ready to merge.

Contributor

chrisroos commented Oct 14, 2015

I've rebased on master and force pushed ready to merge.

chrisroos added a commit that referenced this pull request Oct 14, 2015

Merge pull request #2004 from alphagov/update-checksum-data-for-redun…
…dancy-smart-answers

Update checksum data for redundancy smart answers

@chrisroos chrisroos merged commit 8c26d9f into master Oct 14, 2015

1 check passed

default "Build #3098 succeeded on Jenkins"
Details

@chrisroos chrisroos deleted the update-checksum-data-for-redundancy-smart-answers branch Oct 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment