Spike: Fail fast on missing methods in SmartAnswer::State object #2071
This has been superseded by PR #2099
This is for discussion only and currently contains 4 failing tests that I've not investigated fully.
The main change in this PR overrides
I've also updated all Smart Answer flows where the code was relying on the old behaviour of the
I'm not 100% convinced about this but would like to hear what other people think.
I think this is a worthwhile change. It's not ideal that we have to introduce so many missing variables, but then that's kind of the point! Is that what you are unconvinced about?
It would be good to implement
Ideally, I think each flow would automatically instantiate a flow-specific "model" class with the relevant methods defined on it. Then we'd get this kind of behaviour for free. But I think this is a good first step.
Do you think this is necessary given that we've not had it before now?
Interestingly, it would appear that