Remove unused FCOEmbassyScraper #2403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
* This class was added 4 years ago in 2012 [1]. * There are no references to it in the code or the documentation. * I'm not aware of any developers using it in the last year or so. * The `www.fco.gov.uk` URL which it scrapes now redirects to a page on `www.gov.uk` [2], which I think is the source for the Worldwide API that the app is currently using to obtain embassy data anyway. [1]: 0c19b15 [2]: https://www.gov.uk/government/world/organisations
This file was used by `LegacyCountry` and by `FCOEmbassyScraper`, but these have now both been removed and so this file is no longer needed and can be removed.
floehopper
force-pushed
the
remove-fco-embassy-scraper
branch
from
af92e8b
to
f39634d
Compare
|
Rebasing against master, removing temporary squash commit and force-pushing in preparation for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note that this PR includes a squash commit of the branch from #2402 which I plan to remove before merging.
External changes
None.