Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fail fast in regression test if response is not success #2519
When generating regression test artefacts for the first time, we should never store a response with a non-success status code - this would be a sign that we've chosen the wrong questions & responses.
When running regression tests on subsequent occasions, it's more useful to see an assertion failure specifically about the non-success response, rather than an assertion about the response body diff not matching.
I did consider avoiding the duplication by putting the assertion inside
None. This only affects test code.
Thanks for reviewing.
No, but I did see them being generated and it reminded me that I think some of them have been committed by accident previously.