Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Vietnam-specific link to consular fees #2525

Closed

Conversation

Projects
None yet
2 participants
@chrisroos
Copy link
Contributor

commented May 13, 2016

The consular_fees_in_cash_visa_master partial was a Vietnam specific version
of the link_to_consular_fees. Si Stephens has confirmed that it's not
necessary (see https://trello.com/c/K2bUzopZ).

I've run the regression tests, updated the artefacts and checksum data all in
this commit because it's such a small/easy to understand change.

Expected changes

This affects all 15 Vietnam outcomes.

Before

pr-2525-before

After

pr-2525-after

Remove Vietnam specific link to consular fees
The `consular_fees_in_cash_visa_master` partial was a Vietnam specific version
of the `link_to_consular_fees`. Si Stephens has confirmed that it's not
necessary (see https://trello.com/c/K2bUzopZ).

I've run the regression tests, updated the artefacts and checksum data all in
this commit because it's such a small/easy to understand change.
@floehopper

This comment has been minimized.

Copy link
Contributor

commented May 13, 2016

Given that this looked relatively uncontroversial, I decided to review it even though it's waiting on fact-check.

It all looks good to me from a technical point of view.

@chrisroos

This comment has been minimized.

Copy link
Contributor Author

commented May 26, 2016

Hey @sistephens. Can you factcheck this change, please?

@chrisroos

This comment has been minimized.

Copy link
Contributor Author

commented Jun 2, 2016

This has come back from fact check and it turns out that we do need this Vietnam-specific paragraph so I'm closing this PR.

@chrisroos chrisroos closed this Jun 2, 2016

@chrisroos chrisroos deleted the remove-vietnam-specific-link-to-consular-fees branch Jun 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.