Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display marriage-abroad services and fees for ceremonies in France, Monaco and French overseas territories #2526

Conversation

Projects
None yet
3 participants
@chrisroos
Copy link
Contributor

commented May 13, 2016

Trello cards: https://trello.com/c/JRlOtA86 and https://trello.com/c/7TlLXjXb.

This branch adds the services/fees information to outcomes for France, Monaco and the French overseas territories.

Expected changes

  • Marriage in France
    • Before - No services
    • After - "Issuing a certificate of custom and law" service/fee
  • PACS in France
    • Before - No services
    • After - "Issuing a certificate of custom and law" service/fee
  • Marriage in New Caledonia
    • Before - No services
    • After - "Issuing a certificate of custom and law" service/fee
  • PACS in New Caledonia
    • Before - No services
    • After - "Issuing a certificate of custom and law" service/fee
  • Marriage in Wallis and Futuna
    • Before - No services
    • After - "Issuing a certificate of custom and law" service/fee
  • PACS in Wallis and Futuna
    • Before - No services
    • After - "Issuing a certificate of custom and law" service/fee
  • Marriage in Monaco
    • Before - No services
    • After - "Issuing a certificate of custom and law" service/fee
  • PACS in Monaco
    • Before - No services
    • After - "Issuing a certificate of custom and law" service/fee
  • Ceremonies in French Guiana
    • Before - No services
    • After - "Issuing a certificate of custom and law" service/fee
  • Ceremonies in French Polynesia
    • Before - No services
    • After - "Issuing a certificate of custom and law" service/fee
  • Ceremonies in Guadeloupe
    • Before - No services
    • After - "Issuing a certificate of custom and law" service/fee
  • Ceremonies in Martinique
    • Before - No services
    • After - "Issuing a certificate of custom and law" service/fee
  • Ceremonies in Mayotte
    • Before - No services
    • After - "Issuing a certificate of custom and law" service/fee
  • Ceremonies in Reunion
    • Before - No services
    • After - "Issuing a certificate of custom and law" service/fee
  • Ceremonies in St Pierre & Miquelon
    • Before - No services
    • After - "Issuing a certificate of custom and law" service/fee
@sistephens

This comment has been minimized.

Copy link
Contributor

commented May 13, 2016

Hey @chrisroos. The preview links are all https://smart-answers-pr-2525.herokuapp.com. You meant them to be https://smart-answers-pr-2526.herokuapp.com right?

@sistephens

This comment has been minimized.

Copy link
Contributor

commented May 13, 2016

@chrisroos Looks good to me! Thanks.

@floehopper floehopper self-assigned this May 13, 2016

@floehopper

This comment has been minimized.

Copy link
Contributor

commented May 13, 2016

Given that it sounds as if this has been given the go-ahead, I've taken the liberty of reviewing the code.

This all looks good to me from a technical point of view.

@chrisroos

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2016

Hey @chrisroos. The preview links are all https://smart-answers-pr-2525.herokuapp.com. You meant them to be https://smart-answers-pr-2526.herokuapp.com right?

I did indeed, @sistephens! Sorry! I've updated the description and the links should all now be correct.

@chrisroos

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2016

Thanks for reviewing, @sistephens and @floehopper. I'm going to get this rebased and merged.

chrisroos added some commits May 10, 2016

Update responses-and-expected-results for marriage-abroad
Based on the addition of the French overseas territories in the previous
commit.
Add support for default services irrespective of partner sex
This will allow me to add services for France, Monaco and the French overseas
territories. We don't need to know the sex of your partner for ceremonies in
these countries.
Update questions-and-responses for marriage-abroad
I'm in the process of adding the services/fees information to the outcomes for
France, Monaco and the French overseas territories (that is, France, Monaco as
well as countries in `FRENCH_OVERSEAS_TERRITORIES`).

The full set of countries affected is:

* france
* french-guiana
* french-polynesia
* guadeloupe
* martinique
* mayotte
* monaco
* new-caledonia
* reunion
* st-pierre-and-miquelon
* wallis-and-futuna

I've added the missing countries so that we generate regression test artefacts
for all countries listed above.
Update regression test artefacts for marriage-abroad
The additions are all for the French overseas territories that I recently added
to the marriage-abroad regression test data.
Update services for France, Monaco and French overseas territories
This is in preparation for displaying the `consular_fees_table` in the outcomes
for the aforementioned countries.

We don't ask for the sex of your partner in these countries so the same service
applies to all ceremonies.
Display services/fees in outcome_marriage_in_france_or_french_oversea…
…s_territory

Si Stephens has confirmed that we don't need to display a link to the consular
fees, or any payment information (e.g. "you can pay by cash") in this outcome.

This outcome is shown for marriages in France, New Caledonia and Wallis and
Futuna (countries that offer PACS) and is shown for all ceremonies in the other
French overseas territories.
Display services/fees in outcome_civil_partnership_in_france_or_frenc…
…h_overseas_territory

Si Stephens has confirmed that we don't need to display a link to the consular
fees, or any payment information (e.g. "you can pay by cash") in this outcome.

This outcome is shown for PACS in France, New Caledonia and Wallis and Futuna.
Display services/fees in Monaco outcomes
Si Stephens has confirmed that we don't need to display a link to the consular
fees, or any payment information (e.g. "you can pay by cash") in this outcome.
Update regression test checksums for marriage-abroad
The marriage-abroad regression tests are passing so I'm happy to update this
checksum data.

@chrisroos chrisroos force-pushed the display-marriage-abroad-services-and-fees-for-ceremonies-in-france-monaco-and-french-overseas-territories branch from 5b327da to 9ece040 May 15, 2016

@chrisroos

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2016

I've force pushed the branch in preparation for merging to master. There were no commit comments so we haven't lost anything through the force push.

@chrisroos chrisroos merged commit 89bf676 into master May 15, 2016

1 check passed

default "Build #5125 succeeded on Jenkins"
Details

@chrisroos chrisroos deleted the display-marriage-abroad-services-and-fees-for-ceremonies-in-france-monaco-and-french-overseas-territories branch May 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.