Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gds-api-adapters from v25.1.0 to v30.6.0 (the latest version) #2552

Merged
merged 2 commits into from Jun 2, 2016

Conversation

Projects
None yet
2 participants
@floehopper
Copy link
Contributor

commented May 26, 2016

Description

I noticed that we were using quite an old version of gds-api-adapters and I thought it would be sensible to get more up-to-date.

Also I'm contemplating pushing some functionality out of the smart-answers app and into gds-api-adapters. Being up-to-date with gds-api-adapters will make this easier.

This PR updates gds-api-adapters from v25.1.0 to v30.6.0 (the latest version). It also updates one of its dependencies, plek, from v1.7.0 to v1.12.0 (the latest version). Strictly speaking it was only necessary to update plek to v1.9.0, but I decided I might as well update it to the latest version as well.

I've run all the regression tests locally and they all pass.

See individual commit notes for more details.

External changes

None. This is just an internal refactoring.

@chrisroos chrisroos self-assigned this Jun 2, 2016

@chrisroos

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2016

Looks good to me, @floehopper.

@floehopper

This comment has been minimized.

Copy link
Contributor Author

commented Jun 2, 2016

@chrisroos: Thanks for reviewing. Rebasing against master and force-pushing in preparation for merging.

floehopper added some commits May 26, 2016

Update plek from v1.7.0 to v1.12.0
I want to update gds-api-adapters to the latest version (v30.6.0) and that
depends on the plek version being >= v1.9.0.

I looked through CHANGELOG for plek and didn't see anything that worried me.

I made the change to version of plek in the Gemfile and ran
`bundle update plek`. I then inspected the changes to Gemfile.lock
and since only the version of plek was affected, I accepted the changes as they
stood.

I've also run all the non-regression tests and they all pass. I intend to run
all the regression tests locally before I submit this branch as a PR.

Note that I've stuck with constraining plek to a specific version in the
Gemfile, even though I think this is overkill. We seem to be inconsistent about
how we approach the constraints on gems in the Gemfile, but I'm not going to
worry about that in this PR.
Update gds-api-adapters from v25.1.0 to v30.6.0
I noticed that we were using quite an old version of gds-api-adapters and I
thought it would be sensible to get more up-to-date.

Also I'm contemplating pushing some functionality out of the smart-answers app
and into gds-api-adapters. Being up-to-date with gds-api-adapters will make this
easier.

I looked through CHANGELOG for gds-api-adapters and didn't see anything that
worried me. Most of the changes seemed to be additions to the API.

I made the change to version of gds-api-adapters in the Gemfile and ran
`bundle update gds-api-adapters`. I then inspected the changes to Gemfile.lock
and removed the following unnecessary changes:

* domain_name (v0.5.25 -> v0.5.20160310)
* mime-types (v2.99.1 -> v2.99.2)
* rack-cache (v1.5.1 -> v1.6.1)
* unf_ext (v0.0.7.1 -> v0.0.7.2)

I've run all the tests including the regression tests and they all pass.

Note that I've stuck with constraining gds-api-adapters using the
`~> major-version.minor-version` style. We seem to be inconsistent about
how we approach the constraints on gems in the Gemfile, but I'm not going to
worry about that in this PR.

@floehopper floehopper force-pushed the update-gds-api-adapters branch from f7db50f to a4fc827 Jun 2, 2016

@floehopper floehopper merged commit 167ea8a into master Jun 2, 2016

1 check passed

default "Build #5287 succeeded on Jenkins"
Details

@floehopper floehopper deleted the update-gds-api-adapters branch Jun 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.