Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split marriage-abroad outcome for Kuwait #2621

Merged
merged 8 commits into from Jul 11, 2016

Conversation

Projects
None yet
2 participants
@chrisroos
Copy link
Contributor

commented Jul 6, 2016

The current outcome template (outcome_opposite_sex_marriage_in_kuwait)
contains three logical outcomes:

  • One for residents of the UK
  • One for residents of Kuwait
  • One for residents of a third country

The outcome body contains a single if/else statement that decides which
logical outcome to display. Splitting these logical outcomes and moving the
"routing logic" to the flow is more consistent with the majority of this Smart
Answer.

@chrisroos chrisroos force-pushed the split-marriage-abroad-outcome-for-kuwait branch from 04bda0d to eb03d14 Jul 6, 2016

@floehopper floehopper self-assigned this Jul 7, 2016

@floehopper

This comment has been minimized.

Copy link
Contributor

commented Jul 7, 2016

LGTM 👍

chrisroos added some commits Jun 23, 2016

Add Kuwait outcome for residents of UK
The new template is a duplicate of
outcome_opposite_sex_marriage_in_kuwait.

I'll remove the logic and content for residents outside the UK in a subsequent
commit.
Add Kuwait outcome for residents of Kuwait
The new template is a duplicate of outcome_opposite_sex_marriage_in_kuwait.

I'll remove the logic and content for residents outside Kuwait in a subsequent
commit.
Prepare for splitting the Kuwait outcome
The current outcome template (outcome_opposite_sex_marriage_in_kuwait)
contains three logical outcomes:

* One for residents of the UK
* One for residents of Kuwait
* One for residents of a third country

The outcome body contains a single `if/else` statement that decides which
logical outcome to display. Splitting these logical outcomes and moving the
"routing logic" to the flow is more consistent with the majority of this Smart
Answer.

This change will make it easier to split the outcome in a subsequent commit.
Rename Kuwait outcome for residents of third country
I'll remove the logic and content for residents in the UK or Kosovo in a
subsequent commit.
Update Kosovo outcome for residents of the UK
I've removed all the logic/content related to residents outside of the UK.

This diff is best viewed using the `--ignore-all-space` option.
Update Kuwait outcome for residents of a third country
I've removed all the logic/content related to residents of the UK or Kuwait.

This diff is best viewed using the `--ignore-all-space` option.
Update Kuwait outcome for residents of Kuwait
I've removed all the logic/content related to residents of the UK or a third
country.

This diff is best viewed using the `--ignore-all-space` option.
Update regression test checksum data for marriage-abroad
Updating as the marriage-abroad regression tests are passing.

@chrisroos chrisroos force-pushed the split-marriage-abroad-outcome-for-kuwait branch from eb03d14 to bf9fe0f Jul 11, 2016

@chrisroos

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2016

I've rebased this on master and force pushed in preparation for merging.

@chrisroos chrisroos merged commit 30bcf61 into master Jul 11, 2016

1 check passed

default "Build #5650 succeeded on Jenkins"
Details

@chrisroos chrisroos deleted the split-marriage-abroad-outcome-for-kuwait branch Jul 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.