Skip to content
This repository has been archived by the owner. It is now read-only.

Clean up whitespace at bottom of page #107

Merged
merged 2 commits into from Feb 9, 2016
Merged

Clean up whitespace at bottom of page #107

merged 2 commits into from Feb 9, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Feb 8, 2016

  • Stop the “report a problem” link from floating too high above the footer
  • Clarify purpose of a govuk-component override

(An upcoming change to the default margins on the document-footer component in static will increase the gap between report a problem and the footer to 45px to make that gap consistent)

Before

screen shot 2016-02-08 at 16 01 11

After

screen shot 2016-02-08 at 16 04 41

fofr added 2 commits Feb 8, 2016
This change makes sense but wasn’t explained.

We don’t want longer definition terms by default, as for most uses it
would be too wide. The metadata component could in the future take a
“long” flag like the title does.
Stop the “report a problem” link from floating too high above the footer
gpeng added a commit that referenced this pull request Feb 9, 2016
Clean up whitespace at bottom of page
@gpeng gpeng merged commit 7540efd into master Feb 9, 2016
1 check passed
1 check passed
default Build #353 succeeded on Jenkins
Details
@gpeng gpeng deleted the fix-page-padding branch Feb 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.