Skip to content
This repository has been archived by the owner. It is now read-only.

Alter margins in preparation for component margin updates #108

Merged
merged 2 commits into from Feb 9, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Feb 8, 2016

  • We’re adding a default margin to the bottom of the govuk-metadata component (alphagov/static@cd57d93). If that were to go live as-is, then that margin would double up with the summary’s padding. Before we deploy the change to the metadata component we need to remove the summary padding and add a temporary margin bottom so that everything looks correct between deploys.
  • Remove unnecessary padding-top styles above header. The title component provides a top margin. No other vertical spacing is needed between the banner and the title.

This must be merged and deployed before alphagov/static#730

fofr added 2 commits Feb 8, 2016
We’re adding a default margin to the bottom of the `govuk-metadata`
component. If that were to go live as-is, then that margin would double
up with the summary’s padding.

Before we deploy the change to the metadata component we need to remove
the summary padding and add a temporary margin bottom so that
everything looks correct between deploys.
The title component provides a top margin. No other vertical spacing is
needed between the banner and the title.
gpeng added a commit that referenced this pull request Feb 9, 2016
Alter margins in preparation for component margin updates
@gpeng gpeng merged commit ddd7d30 into master Feb 9, 2016
1 check passed
1 check passed
default Build #355 succeeded on Jenkins
Details
@tijmenb tijmenb deleted the alter-component-margins branch Aug 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.