This repository has been archived by the owner. It is now read-only.

Drop finder api #77

merged 4 commits into from Jan 8, 2015


None yet
2 participants

tommyp commented Jan 7, 2015

As we want to drop FInder API from the Finders stack we need to make Specialist Frontend use the Content Store. This involves:

  • adding a new Finder model class and doing the value to label conversion there instead of Finder API
  • use this model instead of passing around a Schema
  • stubbing the content store in the feature tests
  • use the Finder model in the controller spec

tommyp added some commits Jan 7, 2015

Add Finder model
As we move away from Finder API we need to introduce a Finder object to
do the value to label conversion. This code is pretty much exactly the
same as what was in the API adapters other than it now always casts
value to an Array in line 28. This is because we no longer use single
selects in Finders.
Use Finder model in Specialist Documents
This involves just using the Finder model and passing in the content
item and renaming schema to Finder in the App.
Use content store in features
This involves renaming schemas to Finders, replacing the finder API
support file with content store and replacing the stubbed schemas with
the content store responses.

evilstreak added a commit that referenced this pull request Jan 8, 2015

@evilstreak evilstreak merged commit 707aa32 into master Jan 8, 2015

1 check passed

default Build #251 succeeded on Jenkins

@evilstreak evilstreak deleted the drop-finder-api branch Jan 8, 2015

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.